Skip to content

Bump Go stream client to v0.13-alpha #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ansd merged 10 commits into from
Sep 3, 2021
Merged

Bump Go stream client to v0.13-alpha #756

ansd merged 10 commits into from
Sep 3, 2021

Conversation

@ansd
Copy link
Member

@ansd ansd commented Jul 2, 2021 •
edited
Loading

@Gsantomaggio I bumped the Go stream client in the system tests to latest released v0.7-alpha.
System tests are now failing with

• Failure [26.663 seconds]
Operator
/home/runner/work/cluster-operator/cluster-operator/system_tests/system_test.go:35
  when (web) MQTT, STOMP, and stream plugins are enabled
  /home/runner/work/cluster-operator/cluster-operator/system_tests/system_test.go:537
    publishes and consumes a message [It]
    /home/runner/work/cluster-operator/cluster-operator/system_tests/system_test.go:568

    Unexpected error:
        <*net.DNSError | 0xc0007ad180>: {
            Err: "no such host",
            Name: "mqtt-stomp-stream-server-0.mqtt-stomp-stream-nodes.rabbitmq-system",
            Server: "",
            IsTimeout: false,
            IsTemporary: false,
            IsNotFound: true,
        }
        lookup mqtt-stomp-stream-server-0.mqtt-stomp-stream-nodes.rabbitmq-system: no such host
    occurred

    /home/runner/work/cluster-operator/cluster-operator/system_tests/utils.go:971

because https://github.com/rabbitmq/rabbitmq-stream-go-client/blob/3356a455a15a24877ca82911594ad64c842008a3/pkg/stream/server_frame.go#L426 adds a wrong hostname and port: It adds the K8s internal hostname mqtt-stomp-stream-server-0.mqtt-stomp-stream-nodes.rabbitmq-system instead of the K8s node IP address and it adds port 5552 instead of the K8s node port although K8s node IP address and K8s node port are set in

cluster-operator/system_tests/utils.go

Lines 952 to 953 in 6f1c4df

Host: host,
Port: port,

The Go client in the system tests runs outside the K8s cluster.
System tests use Service type NodePort.

Is there a way to use the Go client outside a K8s cluster with Service type NodePort?
It used to work with the older version github.com/rabbitmq/rabbitmq-stream-go-client v0.0.0-20210422170636-520637be5dde.

@ansd ansd force-pushed the bump-stream-go-client branch from ac1b411 to 5f013a7 Compare September 3, 2021 12:45
@Gsantomaggio Gsantomaggio changed the title Bump Go stream client to v0.7-alpha Bump Go stream client to v0.13-alpha Sep 3, 2021
@Gsantomaggio Gsantomaggio marked this pull request as ready for review September 3, 2021 15:58
@Gsantomaggio
Copy link
Member

Gsantomaggio commented Sep 3, 2021

@ansd sorry for the delay. Now it works :)

@ansd ansd force-pushed the bump-stream-go-client branch from d6a79f2 to ce8b110 Compare September 3, 2021 16:54
@ansd
Copy link
Member Author

ansd commented Sep 3, 2021

This is great @Gsantomaggio, thank you for making it work 🚀

@ansd ansd merged commit 581e6c1 into main Sep 3, 2021
@ansd ansd deleted the bump-stream-go-client branch September 3, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ansd ansd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ansd @Gsantomaggio